[CDRIVER-2450] Altering BSON_STATIC_ASSERT_JOIN2 macro is an API break Created: 04/Jan/18 Updated: 28/Oct/23 Resolved: 12/Jan/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libbson |
| Affects Version/s: | 1.9.0 |
| Fix Version/s: | 1.9.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
4e27abb changed the BSON_STATIC_ASSERT_JOIN2 macro, which is defined in a public header file. This is considered an API break for Fedora. Instead, we should revert BSON_STATIC_ASSERT2 to its original definition and introduce BSON_STATIC_ASSERT3 to fix the original issue in |
| Comments |
| Comment by Githook User [ 10/Jan/18 ] |
|
Author: {'email': 'ppisar@redhat.com', 'name': 'Petr Písař', 'username': 'ppisar'}Message: The macro definition was mistakenly changed in 1.9.0 ( Signed-off-by: Petr Písař <ppisar@redhat.com> |
| Comment by Githook User [ 09/Jan/18 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: BSON_STATIC_ASSERT and related macros must not change signatures. |
| Comment by Remi Collet [ 05/Jan/18 ] |
|
> I'm curious, how did you discover this problem? We used to run various checks: 1/ abi compliance checker See: https://rpms.remirepo.net/compat_reports/libbson/ 2/ rpmdiff 3/ diff on installed tree 4/ build of dependent packages So, mongo-c-driver and php-pecl-mongodb, which was failing |
| Comment by A. Jesse Jiryu Davis [ 05/Jan/18 ] |
|
This was reported by remi. Remi, I'm curious, how did you discover this problem? |