[CDRIVER-2511] Disable warnings for zlib in CMake Created: 16/Feb/18  Updated: 28/Oct/23  Resolved: 01/May/18

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.10.0

Type: Improvement Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to PHPC-1197 Check for unistd.h when compiling bun... Closed
related to CDRIVER-2666 Call bundled zLib's CMake script to a... Backlog
Epic Link: Remove Autotools
Backwards Compatibility: Fully Compatible

 Description   

Evergreen compiles mongo-c-driver with -Werror treating all warnings as errors. The autotools Makefile.am clears the CFLAGS for zLib to prevent zLib warnings showing up.

We should do something similar in CMake. Currently if we specify

-DCMAKE_C_FLAGS="-Werror"

as a CMake option compile will fail from zLib warnings.



 Comments   
Comment by Githook User [ 01/May/18 ]

Author:

{'email': 'kevin.albertson@10gen.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: CDRIVER-2511 disable warnings for bundled zlib

Comment by Githook User [ 07/Apr/18 ]

Author:

{'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}

Message: CDRIVER-2511 disable warnings on Travis
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/459874794a185b7269fa2f5c02ce653abb203a12

Comment by A. Jesse Jiryu Davis [ 02/Apr/18 ]

Once this is done, enable maintainer flags in .travis.yml, compile-unix.sh (and compile-windows.sh?) for Debug and Release builds.

Generated at Wed Feb 07 21:15:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.