[CDRIVER-2572] Only enable counters for shared memory Created: 27/Mar/18 Updated: 28/Oct/23 Resolved: 19/Apr/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tests |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
The shared memory counters fall back to using a regular malloc'ed segment when shared memory is not available. This doesn't seem useful, and means we do an atomic increment every time an operation does an update. So instead, if shared memory segments aren't available, the counters should do nothing. Additionally, we don't have any tests that I'm aware of for the contents of the shared-memory counters. So if we introduce bugs in incrementing the number of active cursors or the number of commands executed, etc., we won't catch it. Create some basic tests that counters are correctly incremented and decremented in response to driver events. |
| Comments |
| Comment by Githook User [ 23/Apr/18 ] |
|
Author: {'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs', 'name': 'Kevin Albertson'}Message: |
| Comment by Githook User [ 20/Apr/18 ] |
|
Author: {'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs', 'name': 'Kevin Albertson'}Message: |
| Comment by Githook User [ 19/Apr/18 ] |
|
Author: {'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs', 'name': 'Kevin Albertson'}Message: |
| Comment by Githook User [ 19/Apr/18 ] |
|
Author: {'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs', 'name': 'Kevin Albertson'}Message: |
| Comment by Githook User [ 19/Apr/18 ] |
|
Author: {'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs', 'name': 'Kevin Albertson'}Message: Counters have a fallback to use a malloc'ed segment of memory if |
| Comment by Kevin Albertson [ 29/Mar/18 ] |
|
Going to do this as a dependency of refactoring cursor code. |