[CDRIVER-2593] CMake 'distcheck' strips make options/switches Created: 05/Apr/18 Updated: 28/Oct/23 Resolved: 18/May/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | cmake |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Roberto Sanchez | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | Remove Autotools | ||||||||
| Description |
|
I recently noticed that the implementation of the 'distcheck' target in the CMake build strips any options that are passed to make. For instance, make -j 8 distcheck will result in a plain invocation of make (without the -j 8). @jesse , what I need to know in order to implement a fix is whether you prefer that the 'distcheck' invocation pass all given parameters to the make that gets invoked for the build, or if it should require the options be specified in a variable, like make distcheck BUILD_OPTS="-j 8". I prefer the variable approach, as it allows specifying different options/switches/variables for different stages of the build (e.g., build, check, install, etc.). Thoughts? |
| Comments |
| Comment by Githook User [ 18/May/18 ] | ||
|
Author: {'username': 'rcsanchez97', 'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com'}Message: | ||
| Comment by Githook User [ 04/May/18 ] | ||
|
Author: {'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez', 'username': 'rcsanchez97'}Message: | ||
| Comment by A. Jesse Jiryu Davis [ 05/Apr/18 ] | ||
|
Yeah, I agree with your approach. I'm curious to see how you do argument-passing like that, as well, because it would be nice to make this possible:
Or even better:
I've opened |