[CDRIVER-2601] Rename CMake variables from _LIBS to _LIBRARIES Created: 07/Apr/18 Updated: 28/Oct/23 Resolved: 30/Apr/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | cmake |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | Remove Autotools |
| Description |
|
While porting config checks from Autotools to CMake we ended up with a mix of variable names, some ending with LIBS and some ending with LIBRARIES. This is a bug factory. For example, if you include SSL_LIBRARIES in a list of dependencies in a pkg-config file, that will be replaced with the empty string which (sometimes!) causes a linker error because it should have been SSL_LIBS. LIBRARIES is the proper convention for CMake variables. For example, the built-in script FindOpenSSL sets OPENSSL_LIBRARIES. Once we've deleted the Autotools scripts let's rename all the LIBS variables to LIBRARIES. This should have no publicly visible effect, these variables are all internal. |
| Comments |
| Comment by Githook User [ 30/Apr/18 ] |
|
Author: {'email': 'jesse@mongodb.com', 'username': 'ajdavis', 'name': 'A. Jesse Jiryu Davis'}Message: Also |