[CDRIVER-2601] Rename CMake variables from _LIBS to _LIBRARIES Created: 07/Apr/18  Updated: 28/Oct/23  Resolved: 30/Apr/18

Status: Closed
Project: C Driver
Component/s: cmake
Affects Version/s: None
Fix Version/s: 1.10.0

Type: Improvement Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: Remove Autotools

 Description   

While porting config checks from Autotools to CMake we ended up with a mix of variable names, some ending with LIBS and some ending with LIBRARIES. This is a bug factory. For example, if you include SSL_LIBRARIES in a list of dependencies in a pkg-config file, that will be replaced with the empty string which (sometimes!) causes a linker error because it should have been SSL_LIBS.

LIBRARIES is the proper convention for CMake variables. For example, the built-in script FindOpenSSL sets OPENSSL_LIBRARIES. Once we've deleted the Autotools scripts let's rename all the LIBS variables to LIBRARIES. This should have no publicly visible effect, these variables are all internal.



 Comments   
Comment by Githook User [ 30/Apr/18 ]

Author:

{'email': 'jesse@mongodb.com', 'username': 'ajdavis', 'name': 'A. Jesse Jiryu Davis'}

Message: CDRIVER-2601 rename LIBS cmake vars to LIBRARIES

Also CDRIVER-2532, libbson should link to ws2_32 if WIN32 is true,
rather linking to it if UNIX is false.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/976085a22be8a630559f7d8a0ae4afb49927c2ed

Generated at Wed Feb 07 21:15:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.