[CDRIVER-2607] brew packaging should honor --HEAD Created: 12/Apr/18 Updated: 28/Oct/23 Resolved: 31/May/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | packaging |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
Many homebrew packages offer --HEAD, which pulls from master of the project. We should offer this for the C driver, for times when the C++ driver master is not currently buildable against the stable C driver. |
| Comments |
| Comment by A. Jesse Jiryu Davis [ 31/May/18 ] | ||||||||||||||||||||||||||||||||||||
|
Homebrew maintainers have already fixed our config to deal with CMake. My PR adding the "head" link has been accepted. | ||||||||||||||||||||||||||||||||||||
| Comment by A. Jesse Jiryu Davis [ 17/Apr/18 ] | ||||||||||||||||||||||||||||||||||||
|
The Autotools build still works on master. There's a wart in src/libbson/autogen.sh, it wants to symlink from README to README.rst in src/libbson, and then the symlink named README is a dependency for the "install" target. The tarball is generated after this symlink is created, so that works in Homebrew, but not when Homebrew builds from a repo clone. If Homebrew executed ./autogen.sh instead of autoreconf, that would probably generate the symlink. If we kept Autotools it would be worthwhile to clean this up, but in the CMake config we're simply not creating the symlink named README and not expecting it to be created. Let's keep this open until someone ports the whole Homebrew formula for the driver to CMake. | ||||||||||||||||||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 17/Apr/18 ] | ||||||||||||||||||||||||||||||||||||
|
OK, so I tried this, following the instructions here: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request. I made the following edit:
But when I try to build it with --HEAD I get an error:
Is the autotools build no longer useable on master for the C driver? If so, I guess we will need to wait until after the upstream homebrew package maintainer switches over to CMake. | ||||||||||||||||||||||||||||||||||||
| Comment by A. Jesse Jiryu Davis [ 12/Apr/18 ] | ||||||||||||||||||||||||||||||||||||
|
Good idea! But we don't maintain the Homebrew package, would you like to open an issue in their tracker? |