[CDRIVER-2654] Remove dead code for MONGOC_ENABLE_SASL_GSSAPI Created: 17/May/18 Updated: 28/Oct/23 Resolved: 11/Jan/19 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | auth, Build |
| Affects Version/s: | 1.7.0 |
| Fix Version/s: | 1.14.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Description |
|
6932241 added support for building against GSS framework (on macOS) and krb5-gssapi; however, the implementation was never completed and I would suggest removing anything that would possibly link either of those two libraries and the MONGOC_ENABLE_SASL_GSSAPI constant (if it's not a BC break). Additionally, _mongoc_cluster_auth_node_gssapi() can be removed. It presently always returns false, which is contrary to its documentation that a {bson_error_t}} would be set on failure. |
| Comments |
| Comment by Githook User [ 11/Jan/19 ] |
|
Author: {'username': 'kevinAlbs', 'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson'}Message: |
| Comment by Kevin Albertson [ 02/Jan/19 ] |
| Comment by A. Jesse Jiryu Davis [ 18/May/18 ] |
|
IIUC we should also remove from src/libmongoc/CMakeLists.txt the option to set ENABLE_SASL=GSSAPI. |