[CDRIVER-2730] Remove redundant logic for placeholders in spec tests Created: 09/Jul/18 Updated: 28/Oct/23 Resolved: 26/Oct/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tests |
| Affects Version/s: | 1.13.0 |
| Fix Version/s: | 1.14.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Most spec tests allow 42 as a placeholder value for cursor ids, error codes, lsids, readConcern.afterClusterTime. So when event callbacks are generated, convert_message_for_test checks these specific fields, converting the actual values to 42 to match what the spec will compare against. However, in the change stream spec tests ( Consequently there's redundancy between what the allow_placeholders flag and the convert_message_for_test function accomplish. |
| Comments |
| Comment by Githook User [ 28/Oct/18 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 26/Oct/18 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}Message: |