[CDRIVER-2756] mongoc_collection_replace_one missing MONGOC_EXPORT in mongoc-collection.h Created: 19/Jul/18 Updated: 28/Oct/23 Resolved: 20/Jul/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | 1.9.0 |
| Fix Version/s: | 1.13.0 |
| Type: | Bug | Priority: | Critical - P2 |
| Reporter: | Bernie Volz | Assignee: | Spencer Mckenney |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | driver | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Issue on Windows as symbol is not available in library. |
||
| Issue Links: |
|
||||||||
| Description |
|
The mongoc_collection_replace_one function is not available in the dynamic library for Windows because the MONGOC_EXPORT is missing from the header file ... see below:
MONGOC_EXPORT (bool) |
| Comments |
| Comment by Spencer Mckenney [ 20/Jul/18 ] |
|
Yep you're right, thanks for pointing this out Bernie. I updated the ticket to reflect that. Closing this issue now as the fix has been merged |
| Comment by Githook User [ 20/Jul/18 ] |
|
Author: {'username': 'spencemc', 'name': 'Spencer McKenney', 'email': 'spencermck@me.com'}Message: |
| Comment by Bernie Volz [ 19/Jul/18 ] |
|
I think this actually impacts 1.9.0 - 1.12: mongo-c-driver 1.9.0 ...
We were using 1.9.2 and it has this issue. We are planning to upgrade, but will likely wait until issue is resolved before updating.
---- Spencer Mckenney updated ---------------------- |
| Comment by A. Jesse Jiryu Davis [ 19/Jul/18 ] |
|
Can you investigate whether our ABI dump / verification tools could be configured to catch this kind of mistake? I.e., any function declared in a public header (a header that's installed, that doesn't have "private" in the filename), but not decorated with MONGOC_EXPORT / BSON_EXPORT. |