[CDRIVER-2758] Improve spelling Created: 19/Jul/18  Updated: 28/Oct/23  Resolved: 23/Jul/18

Status: Closed
Project: C Driver
Component/s: libbson, libmongoc
Affects Version/s: 1.12.0
Fix Version/s: 1.13.0

Type: Improvement Priority: Major - P3
Reporter: Gustaf Neumann Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all


Attachments: Text File mongo-c-driver.patch    

 Description   

You might consider the following patch to improve the spelling in the source files of libmongoc and libbson. it has no functional changes.

i am personally a notorious bad typist, so i wrote some tools to me...



 Comments   
Comment by Githook User [ 23/Jul/18 ]

Author:

{'username': 'ajdavis', 'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com'}

Message: CDRIVER-2758 grammar in bson_array_as_json doc
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/1a76b45acb24fc2c79d204d0731774555af1fe5e

Comment by Githook User [ 23/Jul/18 ]

Author:

{'username': 'ajdavis', 'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com'}

Message: CDRIVER-2758 update regex function comments
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/8dda2a824c9fd653b942b4af3b3722808f5abc28

Comment by Githook User [ 23/Jul/18 ]

Author:

{'username': 'gustafn', 'name': 'Gustaf Neumann', 'email': 'neumann@wu-wien.ac.at'}

Message: CDRIVER-2758 improve spelling in source files
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/62c9c3ca7fef8601f486fa0c3b46f459aa7aae7b

Comment by Gustaf Neumann [ 19/Jul/18 ]

I've rolled my own... it is based on the typos i made myself, and which i found in the code i am working on.... and since i am a lazy person, i wrote a small Tcl script, which is not at all sophisticated. ... but the more typos i make, the better it gets.

Comment by A. Jesse Jiryu Davis [ 19/Jul/18 ]

What spellchecker tool did you use, please? It looks like it's very thorough and accurate.

Comment by Gustaf Neumann [ 19/Jul/18 ]

the pull-request for https://github.com/madler/zlib is as well opened. Many thanks for the nice cooperation.

Comment by Gustaf Neumann [ 19/Jul/18 ]

The pull request is opened. All changes from zlib are omitted, issue a poll request for madler/zlib as well.

Comment by Jeremy Mikola [ 19/Jul/18 ]

This patch should likely exclude changing anything under /src/zlib-1.2.11, since that's a vendored library. Those fixes can be contributed upstream: https://github.com/madler/zlib

Comment by Gustaf Neumann [ 19/Jul/18 ]

ok. i'll try later today...

Comment by Kevin Albertson [ 19/Jul/18 ]

Hi gustafn, thanks for the contribution! Can you open a pull request?

Generated at Wed Feb 07 21:16:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.