[CDRIVER-2772] Encourage users to install a release buid Created: 27/Jul/18 Updated: 28/Oct/23 Resolved: 12/Sep/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | docs, libbson, libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.13.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
We don't include "-DCMAKE_BUILD_TYPE=Release" in the commands in our main install guide; let's include it. |
| Comments |
| Comment by Githook User [ 12/Sep/18 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}Message: | ||||
| Comment by Githook User [ 12/Sep/18 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}Message: | ||||
| Comment by Andrew Morrow (Inactive) [ 30/Jul/18 ] | ||||
|
jesse - Yes, I think you are right, and I'm thinking of the C++ driver, where we have this in the top-level CMakeListst.txt:
I think the C driver should do something similar (and we should probably standardize both on RelWithDebInfo). | ||||
| Comment by A. Jesse Jiryu Davis [ 30/Jul/18 ] | ||||
|
I think the default is no build type. On my Mac, these are the gcc flags CMake passes for each build type:
| ||||
| Comment by Andrew Morrow (Inactive) [ 29/Jul/18 ] | ||||
|
Isn't Release the default? Also, you might want to encourage RelWithDebInfo so that users can give symbolized stack traces, etc? |