[CDRIVER-2839] Refactor header include checks and test in Evergreen Created: 01/Oct/18 Updated: 28/Oct/23 Resolved: 15/Mar/19 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libbson, libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.14.0, 1.15.0 |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
The header checks described in We should consider refactoring them into three files mongoc-header-check.h, consisting of:
bson-header-check.h, consisting of:
And common-header-check.h, consisting of:
We can verify with an Evergreen task that each header (except bson.h and mongoc.h) includes one of these checks directly after the license. We could also use the same check to verify that each file has a license. |
| Comments |
| Comment by Githook User [ 15/Mar/19 ] |
|
Author: {'name': 'Kevin Albertson', 'username': 'kevinAlbs', 'email': 'kevin.albertson@mongodb.com'}Message: |
| Comment by Kevin Albertson [ 07/Mar/19 ] |
|
Closed too soon. I did not add tests. |
| Comment by Githook User [ 11/Oct/18 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}Message: |