[CDRIVER-2848] Build is not reproducible because of timestamp in uninstall script Created: 10/Oct/18  Updated: 28/Oct/23  Resolved: 10/Oct/18

Status: Closed
Project: C Driver
Component/s: Build
Affects Version/s: 1.13.0
Fix Version/s: 1.13.1

Type: Bug Priority: Trivial - P5
Reporter: Ryan Schmidt Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The build of mongo-c-driver is not reproducible, because the uninstall script begins with a comment header like:

# Mongo C Driver uninstall program, generated on Wed Oct 10 02:52:40 CDT 2018

I suggest the "generated on" part of that comment be removed, like this:

--- build/generate-uninstall.cmd.orig	2018-09-17 13:24:45.000000000 -0500
+++ build/generate-uninstall.cmd	2018-10-10 02:57:58.000000000 -0500
@@ -45,7 +45,7 @@
 
 echo.@echo off
 echo.
-echo.REM Mongo C Driver uninstall program, generated on %date% %time%
+echo.REM Mongo C Driver uninstall program
 echo.
 echo.REM Copyright 2018-present MongoDB, Inc.
 echo.REM
--- build/generate-uninstall.sh.orig	2018-09-17 13:24:45.000000000 -0500
+++ build/generate-uninstall.sh	2018-10-10 02:56:15.000000000 -0500
@@ -52,7 +52,7 @@
 fi
 
 printf "#!/bin/sh\n"
-printf "# Mongo C Driver uninstall program, generated on %s\n" "$(date)"
+printf "# Mongo C Driver uninstall program\n"
 printf "\n"
 printf "# Copyright 2018-present MongoDB, Inc.\n"
 printf "#\n"



 Comments   
Comment by Githook User [ 25/Jan/19 ]

Author:

{'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}

Message: CDRIVER-2848 fix generate-uninstall.sh syntax
Branch: r1.13-debian
https://github.com/mongodb/mongo-c-driver/commit/522c558a38e1e15082bcfea0d7100200ac5fd5cf

Comment by Githook User [ 25/Jan/19 ]

Author:

{'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}

Message: CDRIVER-2848 no timestamps in uninstall scripts

Permits reproducible build of the release tarball.
Branch: r1.13-debian
https://github.com/mongodb/mongo-c-driver/commit/dfc2c068e130975ea4c7c67fc0823239ef9c8f58

Comment by Githook User [ 24/Jan/19 ]

Author:

{'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}

Message: CDRIVER-2848 fix generate-uninstall.sh syntax
Branch: r1.13
https://github.com/mongodb/mongo-c-driver/commit/522c558a38e1e15082bcfea0d7100200ac5fd5cf

Comment by Githook User [ 24/Jan/19 ]

Author:

{'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}

Message: CDRIVER-2848 no timestamps in uninstall scripts

Permits reproducible build of the release tarball.
Branch: r1.13
https://github.com/mongodb/mongo-c-driver/commit/dfc2c068e130975ea4c7c67fc0823239ef9c8f58

Comment by Githook User [ 11/Oct/18 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: CDRIVER-2848 fix generate-uninstall.sh syntax
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/b07c4d1bd8356cdab346f8f629d7b8c2a35855f8

Comment by A. Jesse Jiryu Davis [ 10/Oct/18 ]

Thanks for the report!

Comment by Githook User [ 10/Oct/18 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: CDRIVER-2848 no timestamps in uninstall scripts

Permits reproducible build of the release tarball.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/bca1bd6a198293213a0d2643d2c0e3b1888348a2

Generated at Wed Feb 07 21:16:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.