[CDRIVER-2849] Same uninstall script name whether installing mongo-c-driver or libbson Created: 10/Oct/18 Updated: 28/Oct/23 Resolved: 15/Jan/19 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build |
| Affects Version/s: | 1.13.0 |
| Fix Version/s: | 1.13.1 |
| Type: | Bug | Priority: | Trivial - P5 |
| Reporter: | Ryan Schmidt | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | FY2019Q4 Quick Wins (C and CXX) | ||||||||
| Backwards Compatibility: | Minor Change | ||||||||
| Description |
|
In MacPorts, libbson and mongo-c-driver are separately-built and separately-installed packages, dating from when they were distributed as separate source code packages. Now that they are in the same source code package, I have to configure the source with -DENABLE_BSON=ON -DENABLE_MONGOC=OFF to build libbson and with -DENABLE_BSON=SYSTEM -DENABLE_MONGOC=ON to build mongo-c-driver. But in either case, the file $prefix/share/mongo-c-driver/uninstall.sh is installed. This makes libbson and mongo-c-driver conflict with each other. It might be good if the file were instead installed as $prefix/share/libbson/uninstall.sh, if the build has been configured for libbson only. In MacPorts, I don't want an uninstall script to be installed at all, so I would also be happy if there were a way to turn off the installation of the uninstall script. For now, I'll patch the cmake files to do that. |
| Comments |
| Comment by Githook User [ 25/Jan/19 ] |
|
Author: {'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez', 'username': 'rcsanchez97'}Message: also make generation of uninstall optional with default to ON |
| Comment by Githook User [ 24/Jan/19 ] |
|
Author: {'username': 'rcsanchez97', 'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez'}Message: also make generation of uninstall optional with default to ON |
| Comment by Githook User [ 15/Jan/19 ] |
|
Author: {'username': 'rcsanchez97', 'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez'}Message: also make generation of uninstall optional with default to ON |
| Comment by A. Jesse Jiryu Davis [ 10/Oct/18 ] |
|
Understood. If you'd like to make a pull request, we'd gladly accept one. The CMake files should be updated to respect an option, ENABLE_UNINSTALL, which is ON by default but can be turned OFF. And if ENABLE_MONGOC is OFF, then uninstall.sh or uninstall.cmd should be renamed to uninstall-bson. |