[CDRIVER-2862] MinimumOSVersion value of CMAKE_OSX_DEPLOYMENT_TARGET not present in Info.plist Created: 25/Oct/18 Updated: 06/Mar/23 Resolved: 06/Mar/23 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | bgtrack | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
When doing a framework build, the value of CMAKE_OSX_DEPLYOMENT_TARGET should be interpolated into the Info.plist file under the name MinimumOSVersion. It does not appear that CMake does this for us (which is probably a bug in CMake). It seems we can work around this by writing our own template for the Info.plist file rather than relying on the one that CMake uses by default. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 26/Oct/18 ] |
|
Probably nothing right now, but when we want to migrate pod-ification of the C driver to the C/C++ team we would want to see this fixed, either by using the MACOSX_FRAMEWORK_INFO_PLIST workaround, or by fixing upstream in CMake and requiring newest. Can be backlogged for now. |
| Comment by A. Jesse Jiryu Davis [ 26/Oct/18 ] |
|
What's the impact for us please? |
| Comment by Andrew Morrow (Inactive) [ 26/Oct/18 ] |
|
Filed an issue upstream. |
| Comment by A. Jesse Jiryu Davis [ 26/Oct/18 ] |
|
To override the template: https://cmake.org/cmake/help/latest/prop_tgt/MACOSX_FRAMEWORK_INFO_PLIST.html |