[CDRIVER-2920] Fix debian-package-build task Created: 08/Jan/19  Updated: 25/Jan/19  Resolved: 16/Jan/19

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: 1.13.0
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Kevin Albertson Assignee: Roberto Sanchez
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Githook User [ 25/Jan/19 ]

Author:

{'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: CDRIVER-2920 remove ref to debian-package-build
Branch: r1.13-debian
https://github.com/mongodb/mongo-c-driver/commit/5c5e495d4d089bf1f3d3a6a4852e24bca6c29556

Comment by Githook User [ 25/Jan/19 ]

Author:

{'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez', 'username': 'rcsanchez97'}

Message: CDRIVER-2920 remove debian-package-build Evergreen task
Branch: r1.13-debian
https://github.com/mongodb/mongo-c-driver/commit/4e51f43ca33d0fd1f74033ecdb2d9c19dba775d3

Comment by Githook User [ 25/Jan/19 ]

Author:

{'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: CDRIVER-2920 correctly apply 17c145107
Branch: r1.13-debian
https://github.com/mongodb/mongo-c-driver/commit/abca36c555a6b76729b3582ab3ca5f3b695aedb9

Comment by Githook User [ 24/Jan/19 ]

Author:

{'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}

Message: CDRIVER-2920 remove ref to debian-package-build
Branch: r1.13
https://github.com/mongodb/mongo-c-driver/commit/5c5e495d4d089bf1f3d3a6a4852e24bca6c29556

Comment by Roberto Sanchez [ 16/Jan/19 ]

As a result of some changes made between the release of 1.13 and the present, the debian-package-build task will never actually work on the r1.13 branch. As a result, I have removed the task entirely and am closing this ticket "won't fix." The task continues to work correctly on master and will work in future release branches (i.e., r1.14 and beyond).

Comment by Githook User [ 16/Jan/19 ]

Author:

{'username': 'rcsanchez97', 'email': 'roberto@connexer.com', 'name': 'Roberto C. Sánchez'}

Message: CDRIVER-2920 remove debian-package-build Evergreen task
Branch: r1.13
https://github.com/mongodb/mongo-c-driver/commit/4e51f43ca33d0fd1f74033ecdb2d9c19dba775d3

Comment by Roberto Sanchez [ 15/Jan/19 ]

That seems very strange. Your commit abca36c555 included an "extraneous" change (the removal of directory: "mongoc" from line 29 of config.yml). That is actually the hunk that fails apply. However, I think that is just coincidence since the whole diff/patch dance is designed specifically to ensure that the task diffs the changes, resets the working the working directory, then runs the Debian package build with the patch that was created at the start. It makes no sense that the patch does not apply moments later.

I don't have a good explanation for why your build fails, but when I tried to create a patch build for myself, the Debian package build claimed there was nothing in the patch (which doesn't make sense). I will need to take a closer look at this in the morning.

Comment by Kevin Albertson [ 14/Jan/19 ]

I did manually apply the changes from that commit to ./build/config.yml.template, but alas I forgot to run python ./build/generate-evergreen-config.py. I fixed and committed that and I think we're a step closer.

But it's now failing with a different error in this patch build:
https://evergreen.mongodb.com/version/5c3ca5f60ae6063bb01b8288

That error occurs in the logs here:
https://evergreen.mongodb.com/task_log_raw/mongo_c_driver_release_releng_debian_package_build_patch_a5fc79fd31b8f06dfb1d37da051ee3cec8a35527_5c3ca5f60ae6063bb01b8288_19_01_14_15_08_44/0?type=T#L1719

IIUC dpkg-buildpackage is failing to apply the patch for new changes for 1.13.1?

Comment by Githook User [ 14/Jan/19 ]

Author:

{'username': 'kevinAlbs', 'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson'}

Message: CDRIVER-2920 correctly apply 17c145107
Branch: r1.13
https://github.com/mongodb/mongo-c-driver/commit/abca36c555a6b76729b3582ab3ca5f3b695aedb9

Comment by Roberto Sanchez [ 14/Jan/19 ]

kevin.albertson, there was something eerily familiar about this problem and it took a while for me to figure it out. We encountered this problem last year and it was fixed in 17c145107. So then it was quite puzzling that the build you identified (which took place weeks later) was failing with seemingly the same problem. In any event, though you specifically mentioned it in your initial email, I did not catch that this build was on the r1.13 branch. The solution, then, to fixing the debian-package-build task is to cherry-pick 17c145107 onto the r1.13 branch. At the time we made the fix I think we were planning to just move ahead to a 1.14 release that included more changes and it was only after that a 1.13.1 release became necessary.

Generated at Wed Feb 07 21:16:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.