[CDRIVER-2961] Support Retryable Writes on by Default Created: 11/Feb/19  Updated: 28/Oct/23  Resolved: 03/Apr/19

Status: Closed
Project: C Driver
Component/s: libmongoc
Affects Version/s: None
Fix Version/s: 1.15.0

Type: New Feature Priority: Major - P3
Reporter: Rathi Gnanasekaran Assignee: Jeremy Mikola
Resolution: Fixed Votes: 0
Labels: FY2020Q1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CDRIVER-3051 Using multi flag with mongoc_collecti... Closed
depends on CDRIVER-3053 mongoc_collection_remove and delete a... Closed
is depended on by CXX-1732 Support Retryable Writes on by Default Closed
is depended on by PHPC-1324 Support Retryable Writes on by Default Closed
Related
related to CDRIVER-3070 Do not include lsid in commands if to... Closed
related to CDRIVER-3039 Do not warn if retryWrites=false and ... Closed
Epic Link: C 4.2 Support

 Description   

See DRIVERS-531 for details.

Currently, libmongoc warns when setting the retryWrites URI option if crypto is not available (due to the sessions requirement). CDRIVER-3039 changes this warning to only trigger for retryWrites=true, since it's not relevant if the user is disabling retryWrites; however, since retryWrites will not be enabled by default and users may not set the URI option at all it makes the most sense to issue a single warning after URI options are processed and we know the final runtime value (considering the default). As part of this ticket, we should move the warning to mongoc_client_pool_new and _mongoc_client_new_from_uri, which is where we currently error if SSL is enabled in the URI but MONGOC_ENABLE_SSL is not defined.



 Comments   
Comment by Githook User [ 03/Apr/19 ]

Author:

{'name': 'Jeremy Mikola', 'username': 'jmikola', 'email': 'jmikola@gmail.com'}

Message: CDRIVER-2961 move retryWrites warning to client/pool creation

Rather than warn each time retryWrites=true is set on the URI, warn
once when the client/pool is created. This also ensures that we warn
if retryWrites is never explicitly set but defaults to true.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/d050044bc4d496d363368c1a421bc825d2a77561

Comment by Githook User [ 03/Apr/19 ]

Author:

{'name': 'Jeremy Mikola', 'username': 'jmikola', 'email': 'jmikola@gmail.com'}

Message: CDRIVER-2961 retryWrites defaults to true

Also consider txnNumber in test_bulk_max_msg_size.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/9ccf14dc9d9df6e8df3279013cbbf43d6bc23a05

Comment by Githook User [ 03/Apr/19 ]

Author:

{'name': 'Jeremy Mikola', 'username': 'jmikola', 'email': 'jmikola@gmail.com'}

Message: CDRIVER-2961 sync retryable writes and transactions spec tests

Synced with mongodb/specifications@ae12fd2921f92608ad953204b0b280c369b8486d
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/7413000678eba62c05db8ae33382486c881fbd1d

Generated at Wed Feb 07 21:16:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.