[CDRIVER-3091] c driver binaries on Windows are missing a VERSIONINFO resource Created: 17/Apr/19 Updated: 27/Oct/23 Resolved: 24/Oct/23 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 1.25.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Kevin Albertson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | CDRIVER-4577 | ||||||||
| Quarter: | FY24Q4 | ||||||||
| Description |
|
On Windows, it is a best practice for binaries to have a VERSIONINFO resource. This enables users to check the version of the binary without running the code. The version info can be viewed from Explorer, sigcheck from sysinternals or other tools.
References: https://docs.microsoft.com/en-us/windows/desktop/menurc/versioninfo-resource
Example from server: https://github.com/mongodb/mongo/blob/master/src/mongo/db/db.rc |
| Comments |
| Comment by Githook User [ 27/Oct/23 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message:
The MinGW resource compiler (windres) does not appear to keep quotes on arguments passed to the preprocessor.
For consistency with C++ driver.
|
| Comment by Githook User [ 24/Oct/23 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Mark Benvenuto [ 29/Apr/19 ] |
|
Yes. This also applies to the C++ driver. Filed |
| Comment by Kevin Albertson [ 29/Apr/19 ] |
|
mark.benvenuto would this apply to the C++ as well? If so, would you mind creating a CXX ticket and linking? |