[CDRIVER-3134] Append wrapping driver platform data before CFLAGS and LDFLAGS Created: 17/May/19 Updated: 28/Oct/23 Resolved: 21/Jun/19 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.15.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Haris Sheikh (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
This would require some reordering of the handshake construction, given that the platform string is first initialized during _mongoc_handshake_init, which is likely before a wrapping driver would have a chance to call mongoc_handshake_data_append. Note: "posix", "stdc", and compiler info are also appended to the platform string before a wrapping driver's data; however, I'm not too concerned with those fields as their values should be short (unlike CFLAGS and LDFLAGS, which can easily exceed a handshake's size limit). |
| Comments |
| Comment by Githook User [ 26/Jun/19 ] |
|
Author: {'name': 'Haris Sheikh', 'email': 'harissheikh@Hariss-MacBook-Pro.local'}Message: |
| Comment by Githook User [ 21/Jun/19 ] |
|
Author: {'name': 'Haris Sheikh', 'email': 'harissheikh@Hariss-MacBook-Pro.local'}Message: |
| Comment by Jeremy Mikola [ 17/May/19 ] |
|
Alternatively, we might consider dropping CFLAGS and LDFLAGS from client metadata altogether, since it's very likely these values may exceed the handshake limit if set and be truncated (with or without extra driver platform data appended). I suppose this is a question of whether incomplete CFLAGS/LDFLAGS are better than no data at all. Is it possible that truncated CFLAGS could lead to incorrect assumptions? |