[CDRIVER-3173] possible be a bug for _mongoc_socket_wait(..., expire_at = -1) Created: 06/Jun/19  Updated: 28/Oct/23  Resolved: 21/Jun/19

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.15.0

Type: Bug Priority: Major - P3
Reporter: zhihui fan Assignee: Haris Sheikh (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Per design,   the -1 means block all the time.   but during the implementation,  it doesn't check it in MONGOC_ERROR_IS_AGAIN case, see https://github.com/mongodb/mongo-c-driver/blob/master/src/libmongoc/src/mongoc/mongoc-socket.c#L222.
 
should we change it to  "OPERATION_EXPIRED(expire_at)"?  
 
 
Thanks



 Comments   
Comment by Githook User [ 21/Jun/19 ]

Author:

{'name': 'Haris Sheikh', 'email': 'harissheikh@Hariss-MacBook-Pro.local'}

Message: CDRIVER-3173 fixed missing check for MONGOC_ERRNO_IS_AGAIN case under _mongoc_socket_wait
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/283c4a84145a12632205e18ec14797d499aec2f7

Comment by Kevin Albertson [ 17/Jun/19 ]

Thanks for the report zhihuifan!

Generated at Wed Feb 07 21:17:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.