[CDRIVER-3255] refactor test_framework_skip_if_* methods Created: 23/Jul/19 Updated: 07/Mar/23 |
|
| Status: | Backlog |
| Project: | C Driver |
| Component/s: | libmongoc, tests |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Samantha Ritter (Inactive) | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The C driver test framework uses a series of checks to determine whether tests should be run or skipped in different testing environments. These check functions return integers, when it would make more sense for them to return booleans. Also, the check functions' results are interpreted inversely, which means a method like skip_if_auth returns false (or, 0) when there is auth and the test should be skipped. This makes for very confusing code. |