[CDRIVER-3322] Warning logged when destroying client pool if client pool, session created but not used Created: 15/Aug/19 Updated: 28/Oct/23 Resolved: 29/Jun/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.17.0-rc0, 1.17.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kaitlin Mahar | Assignee: | Andrew Witten (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
If you do the following:
A warning is logged:
The warning is coming from the call to mongoc_cluster_stream_for_server in _mongoc_client_end_sessions. This does not happen in single-threaded mode. Haven't experienced any issues because of this, but it seems like the warning should not be logged in this case. Repro code attached |
| Comments |
| Comment by Githook User [ 11/Jul/20 ] |
|
Author: {'name': 'Andrew Witten', 'email': 'andrew.witten@mongodb.com', 'username': 'awitten1'}Message:
|
| Comment by Githook User [ 07/Jul/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: After |
| Comment by Githook User [ 29/Jun/20 ] |
|
Author: {'name': 'Andrew Witten', 'email': 'andrew.witten@mongodb.com', 'username': 'awitten1'}Message:
|
| Comment by Andrew Witten (Inactive) [ 18/Jun/20 ] |
|
PR: https://github.com/mongodb/mongo-c-driver/pull/640 Changes the following: does not push unused server sessions to session_pool to be reused; only pushes if server session has been used. From the perspective of the server, the session does not exist. |