[CDRIVER-3428] Implicitly enable TLS for tlsInsecure and tlsCertificateKeyFilePassword URI opts Created: 06/Nov/19 Updated: 28/Oct/23 Resolved: 16/Dec/19 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tls, uri |
| Affects Version/s: | 1.15.0 |
| Fix Version/s: | 1.15.3 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||
| Description |
|
mongoc_uri_get_tls does not consider the MONGOC_URI_TLSINSECURE and MONGOC_URI_TLSCERTIFICATEKEYFILEPASSWORD constants. This was likely an oversight in the PR for The Unified URI options spec leaves the decision to each driver to implicitly enable TLS if any related options are specified. The C driver has historically done so (even for the "insecure" options like ignoring certs), so it should be a quick fix to add these two options to the list of those considered. The docs for mongoc_uri_get_tls can also be improved to clarify that the function returns true if any TLS option is specified. |
| Comments |
| Comment by Githook User [ 16/Dec/19 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: tlsInsecure and tlsCertificateKeyFilePassword were missing. |
| Comment by Githook User [ 16/Dec/19 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: tlsInsecure and tlsCertificateKeyFilePassword were missing. |
| Comment by Jeremy Mikola [ 06/Nov/19 ] |
|
Cross-referencing with |