[CDRIVER-3573] Do not hardcode VERSION_CURRENT in patch builds or old branches Created: 16/Mar/20 Updated: 28/Oct/23 Resolved: 13/Feb/22 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tests |
| Affects Version/s: | None |
| Fix Version/s: | 1.22.0, 1.22.0-beta0 |
| Type: | Task | Priority: | Trivial - P5 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
calc_release_version.py reports the wrong version if on a non-release non-master branch. This was the cause of abi-compliance-check always failing on patches from GitHub PRs (because they were running from non-master branches). Additionally, calc_release_version.py run from a release non-master branch, uses the --merged option in git, which requires a newer version of git than we have on all variants. Example of a failing task on the r1.17 evergreen project. As a temporary workaround, I've hardcoded VERSION_CURRENT in the evergreen config. |
| Comments |
| Comment by Githook User [ 13/Feb/22 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: Add --next-minor option to calc_release_version.py This allows build scripts to calculate the next minor release. In Evergreen, git will be in a detached HEAD state. Not on a branch. Co-authored-by: Roberto C. Sánchez <roberto@connexer.com> |
| Comment by Githook User [ 15/Sep/20 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}Message: |
| Comment by Githook User [ 24/Jul/20 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}Message: |
| Comment by Roberto Sanchez [ 24/Jul/20 ] |
|
After discussing this kevin.albertson and I have concluded that this hard coding is only required for GitHub PRs. Since Evergreen has an expansion that specifically identifies GitHub PRs (${github_pr_number}) that should be the basis for hard coding the version. Since the reason this is necessary results from the calc_release_version.py script not correctly handling branches of the master branch that are not release branches (i.e., rX.Y form), a future improvement would be to update calc_release_version.py to have an option that treats the current branch the same as the master branch for reasons of computing the version. Once that change is made, the hard coding in config.yml can be updated to communicate that option to calc_release_version.py instead of actually hard coding the version. |
| Comment by Githook User [ 11/Jul/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 02/Jul/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 09/Jun/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 09/Jun/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 25/May/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: Not all evergreen variants have a new enough version of git to run calc_release_version.py on a non-master branch. This fixes patch builds made through GitHub PRs |
| Comment by Githook User [ 07/May/20 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: Not all evergreen variants have a new enough version of git to run calc_release_version.py on a non-master branch. This fixes patch builds made through GitHub PRs |
| Comment by Githook User [ 17/Mar/20 ] |
|
Author: {'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}Message: |