[CDRIVER-3576] Compiler warnings on mingw-w64 Created: 17/Mar/20 Updated: 28/Oct/23 Resolved: 22/Apr/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | mingw |
| Affects Version/s: | 1.16.2 |
| Fix Version/s: | 1.17.0-beta2, 1.17.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeroen Ooms | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Hi! I maintain the R driver, which is based on mongo-c-driver. After upgrading to 1.16.2 we see the following compiler warnings when compiling with -pedantic. These need to be addressed to publish the R package.
And
and
A full build log is available here: https://win-builder.r-project.org/incoming_pretest/mongolite_2.2.0_20200317_230736/Windows/00install.out |
| Comments |
| Comment by Githook User [ 25/May/20 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}Message: |
| Comment by Githook User [ 22/Apr/20 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}Message: |
| Comment by Jeroen Ooms [ 19/Mar/20 ] |
|
I'm not sure. I was testing with -pedantic before, but perhaps the config has changed so that we are hitting new code paths now on Windows. For the R driver we hardcode the config files (because the build servers don't use cmake). We only use mingw-w64 gcc compilers + openssl on Windows, to stick close to the unix config. - https://github.com/jeroen/mongolite/blob/master/src/mongoc/mongoc-config.h - https://github.com/jeroen/mongolite/blob/master/src/bson/bson-config.h
|
| Comment by Kevin Albertson [ 19/Mar/20 ] |
|
Thanks for the report jeroen@berkeley.edu! This is not new code, though this still seems reasonable to fix. I'm curious why this only showed up now. Do you know if the build not compiling with -pedantic, -std=gnu99, or -Wall before? We can try to modify/add to our compilation tests to ensure we don't break this again in the future. |