[CDRIVER-3595] find_and_modify has extraneous checks for write concern inheritance Created: 30/Mar/20 Updated: 28/Oct/23 Resolved: 17/Jul/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc, Transactions |
| Affects Version/s: | None |
| Fix Version/s: | 1.18.0, 1.18.0-alpha |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Andrew Witten (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
As discovered by andreas.braun as part of 1. Write concern is not inherited from the collection if it is unacknowledged. Being unacknowledged should not prevent it from being inherited. It's possible the call to mongoc_write_concern_is_acknowledged was mistaken for mongoc_write_concern_is_default and that the intent was not to inherit the default write concern. 2. An acknowledged write concern is inherited from the collection and applied to an operation within a transaction But transactions should not be inheriting write concerns from the collection. |
| Comments |
| Comment by Githook User [ 17/Jul/20 ] |
|
Author: {'name': 'Andrew Witten', 'email': 'andrew.witten@mongodb.com', 'username': 'awitten1'}Message:
|
| Comment by Andrew Witten (Inactive) [ 12/Jul/20 ] |
| Comment by Kevin Albertson [ 11/Jun/20 ] |
|
The first point might not be an issue, since the server ignores unacknowledged anyways according to jmikola. But the second point is something we should definitely address if that is an issue. |