[CDRIVER-3602] Prefix enum constants in OCSP callback Created: 02/Apr/20 Updated: 28/Oct/23 Resolved: 02/Apr/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tls |
| Affects Version/s: | None |
| Fix Version/s: | 1.17.0-beta, 1.17.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | C 4.4 Support | ||||||||
| Description |
|
The enum values introduced in 8d3aa32 for I suggest changing these to more unique names. Additionally, there are a few cases within _mongoc_ocsp_tlsext_status_cb where the SUCCESS case in our enum is used to check return values from other TLS functions (e.g. OCSP_basic_verify, X509_check_host). I'd suggest we define explicit constants for those functions rather than re-use our internal enum for the callback's return value. |
| Comments |
| Comment by Githook User [ 02/Apr/20 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: Also use specific constants for OCSP and X509 function return values. |
| Comment by Jeremy Mikola [ 02/Apr/20 ] |