[CDRIVER-3672] Remove superfluous memmove calls in mongoc-buffer.c Created: 14/May/20 Updated: 28/Oct/23 Resolved: 16/Jun/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.17.0-rc0, 1.17.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Kevin Albertson | Assignee: | Andrew Witten (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | new-eng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
A mongoc_buffer_t is a small struct with a data pointer, data length, capacity, and reallocation function. Originally, it also had an offset field, which was removed in this commit: A side-effect of that is there are three lines like:
Which are effectively no-ops. One case was removed in https://github.com/mongodb/mongo-c-driver/commit/26137b5c0883bd0705833c0ec9212694d9c88650 but three still remain. |
| Comments |
| Comment by Githook User [ 11/Jul/20 ] |
|
Author: {'name': 'Andrew Witten', 'email': 'awitten1@terpmail.umd.edu', 'username': 'awitten1'}Message: Co-authored-by: Andrew Witten <andrew.witten@Andrews-MacBook-Pro.local> |
| Comment by Githook User [ 16/Jun/20 ] |
|
Author: {'name': 'Andrew Witten', 'email': 'awitten1@terpmail.umd.edu', 'username': 'awitten1'}Message: Co-authored-by: Andrew Witten <andrew.witten@Andrews-MacBook-Pro.local> |
| Comment by Andrew Witten (Inactive) [ 16/Jun/20 ] |