[CDRIVER-3678] /Topology/request_scan_on_error failing Created: 18/May/20  Updated: 28/Oct/23  Resolved: 20/May/20

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.17.0-beta2, 1.17.0

Type: Bug Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: flaky-tests
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CDRIVER-3625 Multi-threaded scanning should scan s... Closed

 Description   

Failing on the waterfall.

Observed here:
https://evergreen.mongodb.com/task/mongo_c_driver_valgrind_ubuntu_test_valgrind_memcheck_mock_server_patch_924184ad11e716b3cdc36cdded2e2aac79f1be8f_5ec2c4cc3066157722545821_20_05_18_17_24_28

Logs:

[2020/05/18 17:52:58.265] FAIL
[2020/05/18 17:52:58.265] Assert Failure: 7917129728 == 7917207859
[2020/05/18 17:52:58.265] /data/mci/3eae20171efa846739a44af128b30fb6/mongoc/src/libmongoc/tests/test-mongoc-topology.c:1855  _test_request_scan_on_error()
[2020/05/18 17:52:58.267] ==103936==
[2020/05/18 17:52:58.267] ==103936== Process terminating with default action of signal 6 (SIGABRT): dumping core
[2020/05/18 17:52:58.267] ==103936==    at 0x644FE97: raise (raise.c:51)
[2020/05/18 17:52:58.267] ==103936==    by 0x6451800: abort (abort.c:79)
[2020/05/18 17:52:58.267] ==103936==    by 0x2C0F10: _test_request_scan_on_error (test-mongoc-topology.c:1855)
[2020/05/18 17:52:58.267] ==103936==    by 0x2C137F: test_request_scan_on_error (test-mongoc-topology.c:1975)
[2020/05/18 17:52:58.267] ==103936==    by 0x2EC80B: TestSuite_RunTest (TestSuite.c:597)
[2020/05/18 17:52:58.267] ==103936==    by 0x2ED0E8: TestSuite_RunSerial (TestSuite.c:868)
[2020/05/18 17:52:58.267] ==103936==    by 0x2ED53C: TestSuite_Run (TestSuite.c:970)
[2020/05/18 17:52:58.267] ==103936==    by 0x1B3CB6: main (test-libmongoc.c:2633)
[2020/05/18 17:52:58.386] ==103936==
[2020/05/18 17:52:58.386] ==103936== HEAP SUMMARY:
[2020/05/18 17:52:58.386] ==103936==     in use at exit: 3,295,334 bytes in 13,343 blocks
[2020/05/18 17:52:58.386] ==103936==   total heap usage: 4,829,748 allocs, 4,816,405 frees, 2,130,025,635 bytes allocated
[2020/05/18 17:52:58.386] ==103936==
[2020/05/18 17:52:58.386] ==103936== For a detailed leak analysis, rerun with: --leak-check=full
[2020/05/18 17:52:58.386] ==103936==
[2020/05/18 17:52:58.386] ==103936== For counts of detected and suppressed errors, rerun with: -v
[2020/05/18 17:52:58.386] ==103936== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
[2020/05/18 17:52:58.403] Begin /Topology/request_scan_on_error, seed 453841683



 Comments   
Comment by Githook User [ 25/May/20 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-3678 fix /Topology/request_scan_on_error

CDRIVER-3615 changed an exotic edge case for parsing errors.
An error with a NotMaster error code, but a "node is recovering" message
is considered a "node is recovering" error for multi-threaded error
handling. So requested scan is expected.

A "node is recovering" error should request scan for multi-threaded, not
single-threaded scanning. The test was making a wrong assertion, but the
check of the assertion was very racy.

This fixes the test and increases the wait to make the test less racy.
Branch: r1.17
https://github.com/mongodb/mongo-c-driver/commit/ad6e9ffef947a09b08368bfcd72fdac2e877dcf7

Comment by Githook User [ 20/May/20 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-3678 fix /Topology/request_scan_on_error

CDRIVER-3615 changed an exotic edge case for parsing errors.
An error with a NotMaster error code, but a "node is recovering" message
is considered a "node is recovering" error for multi-threaded error
handling. So requested scan is expected.

A "node is recovering" error should request scan for multi-threaded, not
single-threaded scanning. The test was making a wrong assertion, but the
check of the assertion was very racy.

This fixes the test and increases the wait to make the test less racy.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/6dbadb53cf3568f733496ec8be7e740d5beca3bf

Comment by Kevin Albertson [ 20/May/20 ]

CDRIVER-3625 requires changing this test considerably, since multi-threaded scanning is now independent on each server (not all at once). After CDRIVER-3625 is merged, this may resolve itself.

Comment by Kevin Albertson [ 20/May/20 ]

Again, on Windows 2013:

https://evergreen.mongodb.com/task/mongo_c_driver_windows_2013_release_compile_45ff8b6a4e9c700fd9e2e2d7de3594ddf2125e1c_20_05_20_14_49_11

Generated at Wed Feb 07 21:18:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.