[CDRIVER-3704] Echo in debian/rules cause debuild error Created: 04/Jun/20  Updated: 28/Oct/23  Resolved: 08/Jun/20

Status: Closed
Project: C Driver
Component/s: debian
Affects Version/s: None
Fix Version/s: 1.17.0-beta2, 1.17.0

Type: Bug Priority: Major - P3
Reporter: Andrew Lipscomb Assignee: Roberto Sanchez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Ubuntu 18.04


Backwards Compatibility: Fully Compatible

 Description   

Fromhttps://github.com/mongodb/mongo-cxx-driver/commit/deb3e38dcccb8ec4074ace9ebfd093237a033d52 which as of today is releases/stable

In debian/rules

ifneq (,$(findstring nodoc,$(DEB_BUILD_OPTIONS)))
echo "Found 'nodoc' in 'DEB_BUILD_OPTIONS'; not building documentation"
DOCS=OFF
else
DOCS=ON
endif

 
The echo line causes a compilation error when the specificed nodoc flag is defined. This is resolved by simply removing the echo - which I do not believe to be legal inside a rules file
 
If it is - then a build dependency is unspecified - the following Dockerfile was used to generate the error
 

 FROM ubuntu:18.04 
RUN apt-get update && apt-get install -y devscripts equivs
COPY mongo-c-driver /mongo-c-driverWORKDIR /mongo-c-driver
RUN DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true mk-build-deps -i --tool "apt-get -o Debug::pkgProblemResolver=no -y"
RUN DEB_BUILD_OPTIONS="nodoc" debuild -uc -us -b



 Comments   
Comment by Githook User [ 08/Jun/20 ]

Author:

{'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}

Message: CDRIVER-3704 fix nodoc in debian/rules
Branch: r1.17
https://github.com/mongodb/mongo-c-driver/commit/53cbf1974c672a2bbaede9dc83a19d5da424f400

Comment by Githook User [ 08/Jun/20 ]

Author:

{'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}

Message: CDRIVER-3704 fix nodoc in debian/rules
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/3cb87a262c0dfb176d30a199ec1be3ad81d8b07e

Comment by Andrew Lipscomb [ 04/Jun/20 ]

Correction - linked the wrong commit 

https://github.com/mongodb/mongo-c-driver/commit/7114f57f9914b7b97995123ac843d3eeeae3e45d

I can't edit the original issue

https://github.com/mongodb/mongo-c-driver/blob/7114f57f9914b7b97995123ac843d3eeeae3e45d/debian/rules#L21

for the exact point and the release built against

Generated at Wed Feb 07 21:18:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.