[CDRIVER-3755] Provide an index creation helper Created: 16/Jul/20 Updated: 28/Oct/23 Resolved: 14/Jun/23 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.24.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | GnG, neweng, rp-track | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | Improve Developer Experience | ||||||||
| Quarter: | FY24Q2 | ||||||||
| Description |
|
This adds some difficulty for users and wrapping drivers in terms of constructing the command and passing supported options. The commitQuorum option is particularly problematic. This option is only supported on 4.4+ servers, and has adverse side-effects on older servers. This is documented by
Since libmongoc does not provide an index creation helper, and generic command helpers should not be validating command specific options, this forces the user / wrapping driver to do this validation. In particular, this required additional server selection and wire version checking in the C++ driver's support of commitQuorum ( This PR discussion has additional context and motivation: https://github.com/mongodb/mongo-c-driver/pull/662#discussion_r454365303. |
| Comments |
| Comment by Githook User [ 14/Jun/23 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message:
Includes the caller's file and line number on error.
This fixes a possible crash if LOCAL_MASTERKEY is not set in the example.
`strlen` was called was before `to_encrypt.value.v_utf8.str` was assigned. This resulted in a `strlen` call with `NULL` argument.
Co-authored-by: vector-of-bool <vectorofbool@gmail.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
--------- Co-authored-by: vector-of-bool <vectorofbool@gmail.com> |
| Comment by Rachelle Palmer [ 14/Feb/22 ] |
|
Flagging for re-triage as I think maybe this can be closed? |