[CDRIVER-3783] compile definitions and include directories should be specified at the target level Created: 31/Aug/20 Updated: 28/Oct/23 Resolved: 31/Aug/20 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build, cmake |
| Affects Version/s: | None |
| Fix Version/s: | 1.18.0, 1.18.0-alpha |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Roberto Sanchez | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
The CMakeLists.txt configuration for the C driver build currently specifies some compile definitions and include directories at the directory level. This was likely done so that the properties would apply to every target in a given directory (e.g., every variant of libbson and every variant of libmongoc). However, this prevents correctly referencing the targets from an external project that includes the C driver as a sub-project in a sub-directory of the parent project build. In order to correct this it is necessary to migrate the specification of compile definitions and include directories to attach them directly to targets in every case. |
| Comments |
| Comment by Githook User [ 31/Aug/20 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}Message: |