[CDRIVER-3802] Remove bits/signum.h include from libmongoc/tests/test-mongoc-cache.c Created: 21/Sep/20  Updated: 28/Oct/23  Resolved: 22/Sep/20

Status: Closed
Project: C Driver
Component/s: libmongoc, tests
Affects Version/s: 1.17.0
Fix Version/s: 1.17.1

Type: Task Priority: Major - P3
Reporter: Dan Bauman Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

alpine linux 3.12 (or any other non-glibc system?)


Backwards Compatibility: Fully Compatible

 Description   

bits/signum.h on ubuntu specifically says not to include directly anyway and the defines should be picked up when including bits/signal.h (they are on alpine linux at least)

 

at worst case, consider simply hardcoding?

{{raise(19) /* 19 = SIGSTOP */ }}

 

here?

https://github.com/mongodb/mongo-c-driver/blob/1.17.0/src/libmongoc/tests/test-mongoc-cache.c#L84



 Comments   
Comment by Githook User [ 22/Sep/20 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-3802 remove bits/signum.h (#685)

Co-authored-by: Dan Bauman <dan@bauman.space>
Branch: r1.17
https://github.com/mongodb/mongo-c-driver/commit/1209d5202a59e61c499a7c686abcf962f48b109f

Comment by Githook User [ 22/Sep/20 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-3802 remove bits/signum.h (#685)

Co-authored-by: Dan Bauman <dan@bauman.space>
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/4cf56367c2af08ce3364a4344bdb41e2b82b7e58

Comment by Kevin Albertson [ 22/Sep/20 ]

Thanks for the report bauman! I agree that including bits/signal.h is unnecessary. This will be fixed in 1.17.1.

Generated at Wed Feb 07 21:19:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.