[CDRIVER-3825] mongoc_cluster_stream_for_server should not BSON_ASSERT on passed-in server_id Created: 17/Dec/20  Updated: 28/Oct/23  Resolved: 04/Jan/21

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.18.0, 1.18.0-alpha

Type: Improvement Priority: Major - P3
Reporter: Samantha Ritter (Inactive) Assignee: Samantha Ritter (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

mongoc_cluster_stream_for_server is called by user-facing methods like mongoc_client_command_simple_with_server_id. Rather than calling BSON_ASSERT and crash a user program, we should instead return a reasonable error if they pass in 0.



 Comments   
Comment by Githook User [ 04/Jan/21 ]

Author:

{'name': 'Samantha Ritter', 'email': 'samantha.ritter@10gen.com', 'username': 'samantharitter'}

Message: CDRIVER-3825 remove BSON_ASSERT for server_id (#713)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/c45bfe2333abb443bc752740a123eeb88970545c

Comment by Samantha Ritter (Inactive) [ 29/Dec/20 ]

PR https://github.com/mongodb/mongo-c-driver/pull/713

Generated at Wed Feb 07 21:19:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.