[CDRIVER-3954] Run all integration tests in versioned API Evergreen tasks Created: 12/Apr/21  Updated: 28/Oct/23  Resolved: 10/May/21

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.18.0, 1.18.0-alpha2

Type: Improvement Priority: Major - P3
Reporter: Benji Rewis (Inactive) Assignee: Andreas Braun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Currently, we're only running the versioned API spec tests against a server with requireApiVersion. We should run all integration tests in the versioned API evergreen task and debug any errors that arise.



 Comments   
Comment by Githook User [ 03/Jun/21 ]

Author:

{'name': 'Andreas Braun', 'email': 'alcaeus@users.noreply.github.com', 'username': 'alcaeus'}

Message: CDRIVER-3954 Run all integration tests in Versioned API evergreen tests (#787)

  • CDRIVER-3917 route all test client and client_pool creation through the test framework
  • small fixes
  • add missing include
  • rename pool method to match client method
  • Refactor test framework client factories to accept API version
  • Revert change in mongoc-cache.c

Despite the #include, the linker does not like this:
tests/test-mongoc-cache.c.o: In function `ping':
src/libmongoc/tests/test-mongoc-cache.c:45: undefined reference to `test_framework_client_new'

  • Run all tests with requireApiVersion=true
  • Fix large_ismaster test
  • Don't set server api when client can't be created
  • Don't use test clients in tests specifically testing server API behaviour
  • Print default API version in test output
  • Set requireApiVersion option earlier
  • Consider apiVersion field when assembling large bulk operation
  • Fix wrong comment wording

Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>

  • Fix inaccurate variable name
  • Remove obsolete todo
  • Document MONGODB_API_VERSION environment variable in contributing docs
  • Document new test methods
  • Fix tests with acceptApiVersion2
  • Update newly added test

Co-authored-by: samantharitter <samantha.ritter@10gen.com>
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
Branch: r1.18
https://github.com/mongodb/mongo-c-driver/commit/58b5849c11f3778bd047ee4e62ac28d8ae63c87a

Comment by Githook User [ 10/May/21 ]

Author:

{'name': 'Andreas Braun', 'email': 'alcaeus@users.noreply.github.com', 'username': 'alcaeus'}

Message: CDRIVER-3954 Run all integration tests in Versioned API evergreen tests (#787)

  • CDRIVER-3917 route all test client and client_pool creation through the test framework
  • small fixes
  • add missing include
  • rename pool method to match client method
  • Refactor test framework client factories to accept API version
  • Revert change in mongoc-cache.c

Despite the #include, the linker does not like this:
tests/test-mongoc-cache.c.o: In function `ping':
src/libmongoc/tests/test-mongoc-cache.c:45: undefined reference to `test_framework_client_new'

  • Run all tests with requireApiVersion=true
  • Fix large_ismaster test
  • Don't set server api when client can't be created
  • Don't use test clients in tests specifically testing server API behaviour
  • Print default API version in test output
  • Set requireApiVersion option earlier
  • Consider apiVersion field when assembling large bulk operation
  • Fix wrong comment wording

Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>

  • Fix inaccurate variable name
  • Remove obsolete todo
  • Document MONGODB_API_VERSION environment variable in contributing docs
  • Document new test methods
  • Fix tests with acceptApiVersion2
  • Update newly added test

Co-authored-by: samantharitter <samantha.ritter@10gen.com>
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/3e9adec1a8baf388ac5732ad57ce0ef7acd8e5fe

Comment by Andreas Braun [ 28/Apr/21 ]

https://github.com/mongodb/mongo-c-driver/pull/787

Generated at Wed Feb 07 21:19:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.