[CDRIVER-3960] Convert CRUD v2 spec tests to unified test format Created: 20/Apr/21 Updated: 28/Oct/23 Resolved: 16/Jun/21 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tests |
| Affects Version/s: | None |
| Fix Version/s: | 1.18.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Backlog - Core Eng Program Management Team | Assignee: | Jeremy Mikola |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | Migrate all Spec Tests to The Unified Test Runner | ||||||||
| Description |
|
DRIVERS Ticket Description
Script Target - If you can read this text, the script has failed
|
| Comments |
| Comment by Githook User [ 21/Jun/21 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: CDRIVER-3895: Remove dots/dollars validation for insert/replace docs (#801)
Also replaces CRUD legacy/v2 tests with unified equivalents for Synced with mongodb/specifications@a124e21be89cbfc78606725c6ed1fa00dc992777
This adds top-level key validation to _mongoc_validate_replace, similar to what existed in _mongoc_validate_update.
Replacement docs will already be validated by _mongoc_validate_replace before this function is reached. This adds logic to ensure "q" and "u" documents are present, similar to what existed in _mongoc_write_command_delete_legacy.
The failure code path is testing that arguments are still validated by mongoc-util.c, despite replacement validation being removed in a previous commit.
This reverts commit bd014ee7995420d5d1d2db8a10348f0b24d09090.
Empty keys can be used as a reliable BSON validation error, since insert, replace, and update all specify BSON_VALIDATE_EMPTY_KEYS in their vflags. Error message expectations are adjusted accordingly. An _id document with a dollar-prefixed key is also used as a reliable server-side validation error.
Allow entire files to be skipped to preempt schema version errors.
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com> |
| Comment by Githook User [ 16/Jun/21 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: CDRIVER-3895: Remove dots/dollars validation for insert/replace docs (#801)
Also replaces CRUD legacy/v2 tests with unified equivalents for Synced with mongodb/specifications@a124e21be89cbfc78606725c6ed1fa00dc992777
This adds top-level key validation to _mongoc_validate_replace, similar to what existed in _mongoc_validate_update.
Replacement docs will already be validated by _mongoc_validate_replace before this function is reached. This adds logic to ensure "q" and "u" documents are present, similar to what existed in _mongoc_write_command_delete_legacy.
The failure code path is testing that arguments are still validated by mongoc-util.c, despite replacement validation being removed in a previous commit.
This reverts commit bd014ee7995420d5d1d2db8a10348f0b24d09090.
Empty keys can be used as a reliable BSON validation error, since insert, replace, and update all specify BSON_VALIDATE_EMPTY_KEYS in their vflags. Error message expectations are adjusted accordingly. An _id document with a dollar-prefixed key is also used as a reliable server-side validation error.
Allow entire files to be skipped to preempt schema version errors.
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com> |
| Comment by Jeremy Mikola [ 07/Jun/21 ] |
|
New tests will be pulled in with CDRIVER-3895. |