[CDRIVER-3964] Unified test runner should append session to all operations that support it Created: 21/Apr/21  Updated: 28/Oct/23  Resolved: 11/Jun/21

Status: Closed
Project: C Driver
Component/s: tests
Affects Version/s: 1.18.0-alpha
Fix Version/s: 1.18.0

Type: Bug Priority: Minor - P4
Reporter: Jeremy Mikola Assignee: Benji Rewis (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CDRIVER-3422 Unified test format Closed
is related to CDRIVER-3963 Add unpinning transaction test for re... Closed

 Description   

While implementing CDRIVER-3963, I realized that libmongoc's unified test runner only appends sessions (i.e. mongoc_client_session_append) for the following operations:

  • operation_create_index
  • operation_create_collection
  • operation_insert_one

This dates back to 56ada16 for CDRIVER-3422, so it looks like this is just an incomplete implementation of the spec intended to pass the original tests from DRIVERS-709.

I plan to add support for "operation_find" in CDRIVER-3963, but wanted to create this ticket to cover all remaining operations that are documented as supporting a "session" option.



 Comments   
Comment by Githook User [ 11/Jun/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: CDRIVER-3964 Append session to all operations in UTR (#798)
Branch: r1.18
https://github.com/mongodb/mongo-c-driver/commit/89701947e26c637de9bfa56b3245e405b8286b34

Comment by Githook User [ 11/Jun/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: CDRIVER-3964 Append session to all operations in UTR (#798)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/a6b3d5e5802118496093563d7e0c57d652133375

Comment by Githook User [ 03/Jun/21 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-3949, CDRIVER-3963, CDRIVER-3966 aborting txn unpins session (#783)

Replace manual assignment with _mongoc_client_session_unpin

Ensures that session arg is appended to operation_find in unified test runner. Other operations will need to be addressed in CDRIVER-3964.

Syncs transaction spec tests with mongodb/specifications@ec326862be443d11f0233cee2de32a95751144df
Branch: r1.18
https://github.com/mongodb/mongo-c-driver/commit/0966559e932c273fc5b2ce75d31f43d6282c98b1

Comment by Benji Rewis (Inactive) [ 26/May/21 ]

https://github.com/mongodb/mongo-c-driver/pull/798

Comment by Githook User [ 26/Apr/21 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-3949, CDRIVER-3963, CDRIVER-3966 aborting txn unpins session (#783)

Replace manual assignment with _mongoc_client_session_unpin

Ensures that session arg is appended to operation_find in unified test runner. Other operations will need to be addressed in CDRIVER-3964.

Syncs transaction spec tests with mongodb/specifications@ec326862be443d11f0233cee2de32a95751144df
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/2d7938aa068a1df70929a161c94642707cb4bd3e

Generated at Wed Feb 07 21:19:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.