[CDRIVER-4024] Skip tests using unsupported operations Created: 11/Jun/21 Updated: 15/Jun/21 Resolved: 15/Jun/21 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | tests |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Benji Rewis (Inactive) | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Description |
|
This came out of a conversation from The C driver does not have a distinct helper, so operation_distinct in the unified test runner just creates a distinct command to send to the server. This does not actually test any C driver functionality, so we should really just skip tests that use distinct operations. We may need to skip more spec tests with unsupported operations (such as collection enumeration variants) in the future, so having a specific function like "is_test_skipped" to explicitly enumerate skipped tests would be helpful. |
| Comments |
| Comment by Kevin Albertson [ 15/Jun/21 ] |
|
We discussed in triage and decided that using the command helpers to run distinct seemed preferable to skipping tests that include distinct. If we skip a test containing a distinct operation, we risk losing test coverage. The test may run one distinct operation but have. The trade-off is additional maintenance burden in the test runner. That can be a case-by-case decision. For distinct it does not seem like much of a maintenance burden to emulate with the command helpers. We can use the is_test_skipped helper introduced in CDRIVER-3895 if we decide to skip future tests on unsupported operations that we do not wish to emulate. |
| Comment by Jeremy Mikola [ 11/Jun/21 ] |
|
CDRIVER-3895 will introduce a mechanism to skip tests for the unified test runner, which may be useful for this task. |