[CDRIVER-4138] Regex decoding error tests in top.json have unexpected, invalid syntax Created: 26/Aug/21  Updated: 28/Oct/23  Resolved: 14/Sep/21

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.19.1

Type: Spec Change Priority: Major - P3
Reporter: Backlog - Core Eng Program Management Team Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split

 Description   

Downstream changes: drivers should sync their BSON corpus spec tests to mongodb/specifications@5fad277. Two regex tests within top.json's decodeErrors array have changed.


Summary

Two decodeErrors tests in top.json incorrectly use $options as a field within $regularExpression. That causes a parsing error, which can interfere with the actual error being expected by the test (using a number instead of a string for pattern or options). This error dates back to mongodb/specifications@c6d7ac8.

Motivation

Who is the affected end user?

Driver test suites may not be properly testing expected types for $regularExpression syntax in Extended JSON.

Is this issue urgent?

No.

Is this ticket required by a downstream team?

No.

Is this ticket only for tests?

Yes.



 Comments   
Comment by Githook User [ 14/Sep/21 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4083 + CDRIVER-4138 (#856)
Branch: r1.19
https://github.com/mongodb/mongo-c-driver/commit/fef05f0c41e5bf03076b8cc6a6227035f2463b16

Comment by Githook User [ 14/Sep/21 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4083 + CDRIVER-4138 (#856)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/95071bf7ade232a943d074b77c0aba766e0fb774

Comment by Kevin Albertson [ 13/Sep/21 ]

PR: https://github.com/mongodb/mongo-c-driver/pull/856

Generated at Wed Feb 07 21:20:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.