[CDRIVER-4199] Add support for the comment field to all helpers Created: 20/Oct/21  Updated: 28/Oct/23  Resolved: 16/May/22

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.22.0, 1.22.0-beta0

Type: Improvement Priority: Major - P3
Reporter: PM Bot Assignee: Jeremy Mikola
Resolution: Fixed Votes: 0
Labels: size-small
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by PHPC-2049 BulkWrite and Query support comment o... Closed
is depended on by PHPLIB-749 Support comment option on command hel... Closed
is depended on by CXX-2400 Add support for the comment field to ... Closed
Issue split
split from DRIVERS-2192 Fix comment helper specification tests Closed
split from DRIVERS-2214 Fix getMore with comment specs Closed
split from DRIVERS-2243 Inherited comment causes OperationFai... Closed
split from DRIVERS-2244 Test getMore with comment on all topo... Closed
split from DRIVERS-742 Add support for the comment field to ... Closed
split from DRIVERS-2290 No error raised for bulkWrite with co... Closed
split from DRIVERS-2188 Add 'comment' option to EstimatedDocu... Closed
split from DRIVERS-2189 getMore helper should explicitly send... Closed
Related
related to CDRIVER-4384 Hint option is undocumented and not v... Closed
related to CDRIVER-4374 Only allow extra fields when matching... Closed
related to CDRIVER-4371 Remove handling of extra options for ... Backlog
related to CDRIVER-4396 Add comment option tests for distinct... Closed
Server Compat: 4.3
Quarter: FY23Q2
Upstream Changes Summary:

DRIVERS-2189:
This ticket changes how getMore command should treat the comment. Drivers should sync unified spec tests find, aggregate, and changeStreams from mongodb/specifications@0fc77cd.


 Description   

This ticket was split from DRIVERS-742, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 25/May/22 ]

Author:

{'name': 'vector-of-bool', 'email': 'vectorofbool@gmail.com', 'username': 'vector-of-bool'}

Message: CDRIVER-4199: Add the "comment" field to getMore commands (#1014)

This adds a missing "comment" value to getMore for changestreams. This
fixes test failures in the changestreams tests, which are not yet
enabled in this branch but has been manually validated locally.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/1a97d00d91e7251482ffa76c9b4e854a384d9ce9

Comment by Githook User [ 16/May/22 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-4199 comment option for CRUD methods and change streams

Sync unified change stream and CRUD tests with mongodb/specifications@b8371eac99679f072672fa9c7c3ecafb279e13f1

Comment option for bulkWrite, insert, update, delete, findAndModify, aggregate, and change stream operations. Attach cursor comment to getMore for MongoDB 4.4+

Surface entity_map_match error if expectResult fails. The entity_map_match error contains relevant information about the failed match (e.g. field path). This is consistent with error reporting for error.expectResult later in the function.

Update server doc links for database, collection, index enumeration. Also moves the retryable reads include for listDatabases to be consistent with other pages.

Use BSON_ASSERT_PARAM for non-null parameter assertions in mongoc-bulk-operation.c.

Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/29da448f7f9d08a4436fa315f6f277a1416381a8

Comment by Githook User [ 06/May/22 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-4309: always use count command for estimatedDocumentCount (#984)

  • always use count command for estimatedDocumentCount
  • Update spec tests for estimatedDocumentCount

Synced with mongodb/specifications@021cbc80e1e444023fd05d8092df4546e639db40

Includes some test changes for CDRIVER-4063 and CDRIVER-4330

  • Ignore "ns not found" error for dropCollection operations

This requires setting MONGOC_ERROR_API_VERSION_2 on clients under test. It was previously only set on the internal client.

Comment by Jeremy Mikola [ 04/May/22 ]

https://github.com/mongodb/mongo-c-driver/pull/982

Comment by Jeremy Mikola [ 29/Mar/22 ]

kevin.albertson: I'm going to add "split from" relationships to all of the related DRIVERS tickets so we can track all required changes in one place. The related CDRIVER tickets can then be deleted.

Generated at Wed Feb 07 21:20:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.