[CDRIVER-4247] #cmakedefine01 preprocessor directives conflicts with PHPC's autotools build system Created: 17/Dec/21  Updated: 28/Oct/23  Resolved: 17/Dec/21

Status: Closed
Project: C Driver
Component/s: libmongoc
Affects Version/s: None
Fix Version/s: 1.21.0

Type: Bug Priority: Critical - P2
Reporter: Jeremy Mikola Assignee: Ezra Chung
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by PHPC-1908 Allow limiting mongos servers with sr... Closed

 Description   

Not sure if "bug" is the correct category for this issue, but "task" did not seem to convey the same sense or urgency.

59aeacb forĀ mongodb/mongo-c-driver#914 recently introduced #cmakedefine01 preprocessor directives. This is problematic for PHPC, which needs to compile its bundled libmongoc dependency with autotools (to comply with PHP's own build system).

Is it feasible to revert this particular change and/or switch to something more portable that achieves the desired outcome of that PR?



 Comments   
Comment by Githook User [ 17/Dec/21 ]

Author:

{'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}

Message: CDRIVER-4247 Replace cmakedefine01 with autotools-compatible equivalent (#917)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/296ff387c776d70a27c933002543a195d3e35ce0

Generated at Wed Feb 07 21:20:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.