[CDRIVER-4373] Do not call mongoc_bulk_operation_set_let unnecessarily Created: 29/Apr/22 Updated: 28/Oct/23 Resolved: 05/May/22 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Bulk API |
| Affects Version/s: | None |
| Fix Version/s: | 1.22.0, 1.22.0-beta0 |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
mongoc_collection_create_bulk_operation_with_opts always calls mongoc_bulk_operation_set_let. If the let option was never specified, this is redundant as mongoc_bulk_operation_new already initializes it to an empty BSON document. Instead, we should gate the setter with a bson_empty check:
|
| Comments |
| Comment by Githook User [ 05/May/22 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: |
| Comment by Jeremy Mikola [ 29/Apr/22 ] |
| Comment by Githook User [ 29/Apr/22 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: |