[CDRIVER-4462] Reconsider the find-cmake.sh script Created: 25/Aug/22  Updated: 28/Oct/23  Resolved: 16/Feb/23

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.24.0

Type: Task Priority: Unknown
Reporter: Roberto Sanchez Assignee: Ezra Chung
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: CDRIVER-4577

 Description   

The find-cmake.sh script (named find_cmake.sh in the libmongocrypt and mongo-cxx-driver projects) could use some rethinking. The initial thought was raised by ezra.chung@mongodb.com in this PR. Here is what he suggested:

Can we drop the complication of system cmake detection in favor of an unconditional download-build-install a fixed CMake version (effectively {{find_cmake}} -> {{install_cmake}})? This would also allow us to consistently guarantee and develop against a known minimum CMake version across all environments.

It is likely that whatever change is made first in the C driver will also need to be synced to both libmongocrypt and mongo-cxx-driver and tickets in those projects will likely need to be created to track the work. Note that there are two occurrences of the script in the libmongocrypt project (one the main .evergreen directory, and another under bindings/node/.evergreen/find_cmake.sh), so any changes in that project will need to take that into consideration.



 Comments   
Comment by Githook User [ 16/Feb/23 ]

Author:

{'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}

Message: CDRIVER-4462 Use CMake 3.25.2 and improve compile scripts (#1205)

  • CDRIVER-4462 Add find-cmake-version.h and find-cmake-latest.sh
  • Use find-cmake-latest.sh in compile.sh scripts
  • Print CMake version after search for verification
  • Ensure build-and-test-with-toolchain uses the correct CMake version
  • Ensure consistent CMake binary usage when compiling libmongocrypt
  • Fix CMake linker selection issue on macos-1014
  • Add required Evergreen expansions to tasks
  • Extract scan-build compile script into compile-scan-build.sh
  • Extract libmongocrypt compilation scripts into compile-libmongocrypt.sh
  • Address several compile and scan-build warnings
  • Reduce output verbosity of build-and-test-with-toolchain
  • Relocate scan-build matrix to config_generator
Generated at Wed Feb 07 21:20:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.