[CDRIVER-4468] Disable ccache by default for versions older than 3.4.3 Created: 31/Aug/22  Updated: 28/Oct/23  Resolved: 15/Sep/22

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.24.0

Type: Improvement Priority: Unknown
Reporter: Kevin Albertson Assignee: Colby Pike
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

This ticket tracks the changes added in https://github.com/mongodb/mongo-c-driver/pull/1029 and https://github.com/mongodb/mongo-c-driver/pull/1031



 Comments   
Comment by Kevin Albertson [ 15/Sep/22 ]

Resolved by https://github.com/mongodb/mongo-c-driver/commit/0648bef65eaa2a8113da55b8e8713add05064a01

Comment by Githook User [ 31/Aug/22 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4468 revert additional ccache checks (#1100)

  • Revert "Do not elide find_package() if MONGO_USE_CCACHE is set (#1031)"

This reverts commit 237bcf8cc2236b4ea1f0b23c0ee7c8c94bf75d6b.

  • Revert "Disable ccache by default for versions older than 3.4.3 (#1029)"

This reverts commit f55cc6ab918a5b0b7647af56315c02a95079ab9f.
Branch: r1.23
https://github.com/mongodb/mongo-c-driver/commit/d0785340415194117fdc2dbda5b377defbad2b54

Comment by Githook User [ 31/Aug/22 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4468 revert additional ccache checks (#1100)

  • Revert "Do not elide find_package() if MONGO_USE_CCACHE is set (#1031)"

This reverts commit 237bcf8cc2236b4ea1f0b23c0ee7c8c94bf75d6b.

  • Revert "Disable ccache by default for versions older than 3.4.3 (#1029)"

This reverts commit f55cc6ab918a5b0b7647af56315c02a95079ab9f.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/d0785340415194117fdc2dbda5b377defbad2b54

Comment by Kevin Albertson [ 31/Aug/22 ]

The changes of https://github.com/mongodb/mongo-c-driver/pull/1029 get an error on my macOS:

$ cmake -DENABLE_MAINTAINER_FLAGS=ON -S$(pwd) -B$(pwd)/cmake-build
 
 
-- The C compiler identification is AppleClang 13.0.0.13000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for a CXX compiler
-- Looking for a CXX compiler - /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- The CXX compiler identification is AppleClang 13.0.0.13000029
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No CMAKE_BUILD_TYPE selected, defaulting to RelWithDebInfo
-- Found ccache: /usr/local/bin/ccache
ccache: invalid option -- n
CMake Error at build/cmake/CCache.cmake:26 (string):
string sub-command REGEX, mode MATCH needs at least 5 arguments total to
command.
Call Stack (most recent call first):
CMakeLists.txt:86 (include)
 
 
 
CMake Warning at build/cmake/CCache.cmake:31 (message):
Could not obtain ccache version from `ccache --version`. Defaulting to
0.1.0.
Call Stack (most recent call first):
CMakeLists.txt:86 (include)
 
 
 
-- Detected ccache version 0.1.0 is less than 3.4.3, which may lead to spurious failures when run in parallel. See https://github.com/ccache/ccache/issues/260 for more information.
-- Compiling with CCache disabled. Enable by setting MONGO_USE_CCACHE to ON

Here are the versions of ccache, perl, and cmake used:

% ccache --version
ccache version 4.4.2
Features: file-storage http-storage redis-storage
 
 
Copyright (C) 2002-2007 Andrew Tridgell
Copyright (C) 2009-2021 Joel Rosdahl and other contributors
 
 
See <https://ccache.dev/credits.html> for a complete list of contributors.
 
 
This program is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free Software
Foundation; either version 3 of the License, or (at your option) any later
version.

% perl --version
 
 
This is perl 5, version 30, subversion 2 (v5.30.2) built for darwin-thread-multi-2level
(with 2 registered patches, see perl -V for more detail)
 
 
Copyright 1987-2020, Larry Wall
 
 
Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.
 
 
Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl". If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

% cmake --version
cmake version 3.23.3
 
CMake suite maintained and supported by Kitware (kitware.com/cmake).

Since this improvement is intended for stability in Evergreen, I plan to revert https://github.com/mongodb/mongo-c-driver/pull/1029 and https://github.com/mongodb/mongo-c-driver/pull/1031 to unblock the 1.23.0 release. This can be investigated after the release.

Generated at Wed Feb 07 21:21:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.