[CDRIVER-4512] Remove legacy shell from test scripts Created: 25/Oct/22  Updated: 22/Jan/24  Resolved: 17/Jan/24

Status: Closed
Project: C Driver
Component/s: Evergreen Tools
Affects Version/s: None
Fix Version/s: 1.26.0

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from DRIVERS-2328 Remove legacy shell from test scripts Implementing
Related
Epic Link: CDRIVER-2733
Upstream Changes Summary:

DRIVERS-2328:
The legacy shell will no longer be installed in the near future. Drivers are encouraged to remove all usages of the legacy shell in their drivers with this Go driver PR serving as inspiration.

All drivers that require the use of the legacy library are required to define the INSTALL_LEGACY_SHELL environment variable to a non-zero value when running MongoDB installation (either by running run-orchestration.sh or by manually invoking download_and_extract() from download-mongoldb.sh). This variable replaces the current SKIP_LEGACY_SHELL variable which will no longer be respected.

The upcoming changes can be tested by using the development branch for this change. In your evergreen functions, locate the git clone command that clones the drivers-evergreen-tools repository and replace it with this command:

git clone https://github.com/alcaeus/drivers-evergreen-tools.git --depth 1 --branch skip-legacy-shell-by-default $DRIVERS_TOOLS

This will show which of your build tasks still need the legacy shell, which can be installed using the INSTALL_LEGACY_SHELL environment variable in that specific task.


 Description   

This ticket was split from DRIVERS-2328, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 22/Jan/24 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4512 run `aws_tester.py` for `session-creds` and `env-creds` test cases (#389)

  • remove `cd`
  • Remove unnecessary `aws_tester.py` command

`aws_setup.sh` runs `aws_tester.py`

  • run `assume-role` setup for `session-creds` and `env-creds` tests
  • note required `MONGODB_BINARIES` env var
  • run `regular` setup for `env-creds` test case
Comment by Githook User [ 17/Jan/24 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4512 do not use `execdir` (#1516)

Resolves insecure error produced by `find`
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/26867012b5982731c728c3b86d7e461f6f7a7b99

Comment by Githook User [ 17/Jan/24 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4512 remove legacy shell from AWS test scripts (#1514)

  • run `setup_secrets.sh` for AWS auth
  • use `aws_setup.sh` instead of legacy shell setup for AWS test cases
  • remove unused `url_encode`
  • make `*.sh` scripts readable and executable in drivers-evergreen-tools
  • add `secrets-export.sh` to .gitignore
  • remove outdated comment
  • remove unnecessary PATH modification
  • remove unused `mongodb_bin_dir`
  • add shellcheck directives

Ignore `aws_setup.sh` since it is in drivers-evergreen-tools

  • add missing `LAMBDA` test case to test without a session token
  • migrate Ubuntu 18.04 AWS tasks to Ubuntu 20.04
  • migrate 6.0+ tasks to Ubuntu 22.04
  • enable tracing and print "aws_auth" trace logs

This is intended to help diagnose spurious observed auth failures

Comment by Githook User [ 12/Jan/24 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4512 run `aws_tester.py` for `session-creds` and `env-creds` test cases (#389)

  • remove `cd`
  • Remove unnecessary `aws_tester.py` command

`aws_setup.sh` runs `aws_tester.py`

  • run `assume-role` setup for `session-creds` and `env-creds` tests
  • note required `MONGODB_BINARIES` env var
  • run `regular` setup for `env-creds` test case
Generated at Wed Feb 07 21:21:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.