[CDRIVER-4629] Remove code paths that assume maxWireVersion < WIRE_VERSION_OP_MSG Created: 26/Apr/23  Updated: 28/Oct/23  Resolved: 27/Apr/23

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.24.0

Type: Improvement Priority: Unknown
Reporter: Ezra Chung Assignee: Ezra Chung
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-4121 Use OP_MSG to authenticate if server ... Closed
is related to CDRIVER-4622 OP_QUERY egress counter may overcount Closed
is related to CDRIVER-4098 Set minWireVersion to 6 (MongoDB 3.6) Closed

 Description   

There is a lot of legacy code that is only executed given maxWireVersion < 6, which is no longer applicable given WIRE_VERSION_MIN is currently set to 6. Remove obsolete code paths that depend on unsupported values of maxWireVersion (less than 6 at time of writing, which happens to be equivalent to WIRE_VERSION_OP_MSG, which a lot of behavior is dependent on) to simplify the implementation.

Followup to CDRIVER-4098. Motivated by CDRIVER-4622.



 Comments   
Comment by Githook User [ 28/Apr/23 ]

Author:

{'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}

Message: CDRIVER-4629 Remove OP_QUERY codepath in mongoc_cluster_run_command_monitored (#1251)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/25f99ee25a277a78c14ec26335be5f71377b7035

Comment by Githook User [ 27/Apr/23 ]

Author:

{'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}

Message: CDRIVER-4629 Remove code requiring maxWireVersion less than WIRE_VERSION_OP_MSG (#1248)

  • Update /retryable_writes/failover to account for WIRE_VERSION_RETRYABLE_WRITE_ERROR_LABEL
  • Update /inheritance/aggregate to account for CDRIVER-3893
  • Remove references to WIRE_VERSION_FIND_CMD
  • Remove references to WIRE_VERSION_KILLCURSORS_CMD
  • Remove references to WIRE_VERSION_FAM_WRITE_CONCERN
  • Remove references to WIRE_VERSION_READ_CONCERN
  • Remove references to WIRE_VERSION_MAX_STALENESS
  • Remove references to WIRE_VERSION_CMD_WRITE_CONCERN
  • Remove references to WIRE_VERSION_COLLATION
  • Remove references to WIRE_VERSION_HINT_SERVER_SIDE_ERROR
  • Remove references to WIRE_VERSION_ARRAY_FILTERS
  • Remove references to WIRE_VERSION_RETRY_READS
  • Remove references to WIRE_VERSION_RETRY_WRITES
  • Remove references to WIRE_VERSION_OP_MSG
Generated at Wed Feb 07 21:21:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.