[CDRIVER-4657] fle2v2-CreateCollection tests expect embedded nulls to be treated specially Created: 01/Jun/23  Updated: 28/Oct/23  Resolved: 13/Jun/23

Status: Closed
Project: C Driver
Component/s: Client Side Encryption
Affects Version/s: None
Fix Version/s: 1.24.0

Type: Task Priority: Minor - P4
Reporter: PM Bot Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from DRIVERS-2619 fle2v2-CreateCollection tests expect ... Implementing
Upstream Changes Summary:

DRIVERS-2619:
This includes a fix to the fle2v2-CreateCollection test assertions. Update the fle2v2-CreateCollection test to this commit: mongodb/specifications@e59a0ac.

If the test previously passed, this may suggest a bug in the test runner of the Client Side Encryption legacy format. The matching behavior of `command_started_event` is expected to reject extra captured fields in the subdocuments of `command`.

This suggests test runners are expected not to allow extra fields in subdocuments of the command. Test runners are not expected to handle null values specially for subdocuments of the command.


 Description   

This ticket was split from DRIVERS-2619, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 13/Jun/23 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: CDRIVER-4657 Prohibit extra fields when matching `command` subdocuments (#1297)

  • prohibit extra fields in command subdocuments
  • call visitor_fn when matching arrays

To check documents in arrays for extra fields.

  • copy fle2v2-CreateCollection

from specifications commit 11af5ba6f2fea610940ddc644d3cdef54a697e73

  • skip check for on `multi` and `upsert` in updates
  • silence scan-build
  • Apply suggested comment rewordings

Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>

  • document handling of visitor_fn return
  • remove unnecessary `void*` cast

---------

Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/984022edf6ee175cdc7f94dc23f8f9d326d6ffd3

Generated at Wed Feb 07 21:21:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.