[CDRIVER-4754] Clarify exactly what code/label fields drivers should inspect to determine retryability Created: 31/Oct/23  Updated: 25/Jan/24  Resolved: 16/Jan/24

Status: Closed
Project: C Driver
Component/s: Retryability
Affects Version/s: None
Fix Version/s: 1.26.0

Type: Spec Change Priority: Major - P3
Reporter: PM Bot Assignee: Jeremy Mikola
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CDRIVER-4798 Test-level runOnRequirements in retry... Closed
depends on CDRIVER-4210 Make retryable write test error label... Closed
Issue split
Related
related to CDRIVER-4808 Do not check writeConcernError in mon... Closed
is related to PHPLIB-1297 Clarify exactly what code/label field... Closed
Upstream Changes Summary:

DRIVERS-1641:
Summary of necessary driver changes

  • Do not use writeConcernError.code in pre-4.4 mongos response to determine retryability.
  • Do not use writeErrors[].code in pre-4.4 server responses to determine retryability.

Commits for syncing spec/prose tests

  • Sync unified retryable writes spec tests with 3e60a7c

 Description   

This ticket was split from DRIVERS-1641, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 16/Jan/24 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-4754 add const modifier to _mongoc_write_error_handle_labels param (#1515)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/43644f8b30c77a018712a2a29e2dba00799ae643

Comment by Jeremy Mikola [ 16/Jan/24 ]

https://github.com/mongodb/mongo-c-driver/pull/1515

Comment by Githook User [ 16/Jan/24 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-4754 pre-4.4 mongos writeConcernError does not determine retryability (#1501)

Synced with mongodb/specifications@3e60a7c5ed07b87a86ce3b9e1ff93558ef0b9be7
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/da1f98cdd0732813ac33f8616c1dda0a4fd6fbf6

Comment by Jeremy Mikola [ 02/Jan/24 ]

https://github.com/mongodb/mongo-c-driver/pull/1501

Comment by Jeremy Mikola [ 02/Jan/24 ]

Will also depend on syncing spec tests in CDRIVER-4798.

Comment by Jeremy Mikola [ 02/Jan/24 ]

Spec tests for DRIVERS-1641 depend on those from DRIVERS-1385, so CDRIVER-4210 will also need to be implemented in conjunction with this ticket.

Comment by Jeremy Mikola [ 22/Dec/23 ]

I'll need to POC this in libmongoc in order to unblock PHPLIB-1297.

Generated at Wed Feb 07 21:21:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.