[CDRIVER-477] 2 minor errors during visual studio 2008 build and link Created: 03/Dec/14  Updated: 03/May/17  Resolved: 25/Feb/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: 1.1.0
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: franckbonin Assignee: Mira Carey
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7 32bit / MSVS 2008



 Description   

Successfully pass VS 2008 compilation with 2 minor change in source code :

1/
at mongo-c-driver-1.1.0\src\mongoc\mongoc-database.c, l. 688 :
variable 'bson_string_t *buf' shall be defined at the begin of _mongoc_database_get_collection_info_legacy function since we compile C only code.

2/
at mongo-c-driver-1.1.0\build\cmake\libmongoc.def, l.144 to l.146 :
mongoc_rand_add,
mongoc_rand_seed and
mongoc_rand_status
symbols shall be removed (since no related C symbols seems to be found)
Keeping this symbol prevent link phase to succeed.



 Comments   
Comment by Mira Carey [ 25/Feb/15 ]

Hello,

Did you run into those errors in the release tarball for 1.1.0, or from master during the RC cycle? The particular line number in 1 doesn't seem to line up with the code that we released and buf is defined at the top of a block, which I believe is acceptable to MSVC. If it's not I'm happy to move it though.

As for 2, the version of libmongoc.def that sits in the 1.1.0 tag also doesn't have those symbols.

For now I'm closing this as went away, as I suspect you encountered these bugs during the RC cycle, but please re-open if they still remain for you.

Regards,
Jason

Generated at Wed Feb 07 21:09:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.