[CDRIVER-4808] Do not check writeConcernError in mongoc_error_has_label() Created: 04/Jan/24  Updated: 04/Jan/24  Resolved: 04/Jan/24

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.26.0

Type: Improvement Priority: Unknown
Reporter: Jeremy Mikola Assignee: Jeremy Mikola
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CDRIVER-3462 Expand use of error labels for Retrya... Closed
is related to CDRIVER-4210 Make retryable write test error label... Closed
is related to CDRIVER-4754 Clarify exactly what code/label field... Closed

 Description   

3ee5fbb for CDRIVER-3462 originally added this logic to mongoc_error_has_label(), but this is not needed. Per DRIVERS-1385, no stable release of the server has ever returned error labels within the writeConcernError field of a command response.

Since syncing spec tests for DRIVERS-1385 in CDRIVER-4210, there is no longer any case where libmongoc would encounter error labels within writeConcernError (they were previously added to synthetic failCommand responses).

This was pointed out by kevin.albertson@mongodb.com in the mongodb/mongo-c-driver#1501 for CDRIVER-4754.



 Comments   
Comment by Githook User [ 04/Jan/24 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: CDRIVER-4808 do not check writeConcernError in mongoc_error_has_label() (#1505)

Server responses do not return errorLabels within writeConcernError. It is only a top-level field.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/fcdee11bf4b0e6db53e3d02575c2ed70981963ea

Comment by Jeremy Mikola [ 04/Jan/24 ]

https://github.com/mongodb/mongo-c-driver/pull/1505

Generated at Wed Feb 07 21:22:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.